Change in osmo-bsc[master]: LCS: add paging reason, return in paging_request_stop()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Oct 1 14:30:43 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20350 )

Change subject: LCS: add paging reason, return in paging_request_stop()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/20350/1/include/osmocom/bsc/paging.h 
File include/osmocom/bsc/paging.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/20350/1/include/osmocom/bsc/paging.h@92 
PS1, Line 92: int paging_request_stop(struct bsc_msc_data **msc_p, enum bsc_paging_reason *reasons_p,
> You may want to get a struc bsc_paging_params* ptr here instead of all cmds.
bsc_paging_params is about launching a Paging Command, so semantically it's not a good match...
you're right that i could pass in bts and bsub with such a struct, and get the msc and reasons returned in the same ... but i don't really like it



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20350
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib28d1599ae4e483727398859d07de4490fbc31f0
Gerrit-Change-Number: 20350
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Oct 2020 14:30:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/de2fa690/attachment.htm>


More information about the gerrit-log mailing list