Change in osmo-ttcn3-hacks[master]: BSSLAP: add some templates

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Oct 1 14:22:08 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20370 )

Change subject: BSSLAP: add some templates
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20370/1/library/BSSLAP_Types.ttcn 
File library/BSSLAP_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20370/1/library/BSSLAP_Types.ttcn@496 
PS1, Line 496: present
> i never really understood these (omit) (value) (present) modifiers

It allows to catch some bugs at compile-time, similar to 'const' in C. Also, it gives one a hint whether the field is optional and can be 'omit'ted, or must be 'present'. 'template (value)' in ts_ templates allows one to pass not only values, but also templates.

> (plus they mess up the universal-ctags ttcn plugin, it doesn't find those that have modifiers)

Then it's a bug in universal-ctags ;)
https://github.com/nokia/ntt can also generate ctags, maybe they're better?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20370/1/library/BSSLAP_Types.ttcn@496 
PS1, Line 496: uint8_t
> omit doesn't make sense on a ts_, and the ta is not optional
Sorry, I meant 'template (value)' of course.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20370/1/library/BSSLAP_Types.ttcn@522 
PS1, Line 522: uint16_t
> but in a ts_ template, a non-optional part does not make sense to be a template??
See my comment above. It allows you to pass templates as parameters.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20370
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6774bb6aefed67ebbfd5da8e52bb463cd6279ed4
Gerrit-Change-Number: 20370
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Oct 2020 14:22:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/424cad3f/attachment.htm>


More information about the gerrit-log mailing list