This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20333 )
Change subject: add BSSLAP coding for Location Services
......................................................................
Patch Set 1:
(5 comments)
https://gerrit.osmocom.org/c/libosmocore/+/20333/1/include/osmocom/gsm/bsslap.h
File include/osmocom/gsm/bsslap.h:
https://gerrit.osmocom.org/c/libosmocore/+/20333/1/include/osmocom/gsm/bsslap.h@37
PS1, Line 37: enum osmo_bsslap_msgt {
> are those defintiions from the protocol spec, or are they osmocom specific? […]
of course 3GPP spec as the doxygen file comment indicates
I thought not using an OSMO_ prefix is deprecated legacy style??
I assumed it's about keeping a sane namespace rather than indicating who invented it.
What if some other library also decides to implement BSSLAP coding and uses the same names?
I can easily move this to protocol/ but do i really have to rename *everything*? :(
https://gerrit.osmocom.org/c/libosmocore/+/20333/1/include/osmocom/gsm/bsslap.h@71
PS1, Line 71:
> why spaces in all these structs?
the blank line separates the actual coded elements from the flag indicating future additions.
the more_items flag doesn't get encoded, it simply indicates to a future user that the struct has more elements that were added in a later version of libosmocore (which we don't need yet)
https://gerrit.osmocom.org/c/libosmocore/+/20333/1/src/gsm/bsslap.c
File src/gsm/bsslap.c:
https://gerrit.osmocom.org/c/libosmocore/+/20333/1/src/gsm/bsslap.c@38
PS1, Line 38: OSMO_BSSLAP_IEI_TA = 0x1,
> those look like 3GPP constants? see my earlier comment.
yes of course
https://gerrit.osmocom.org/c/libosmocore/+/20333/1/src/gsm/bsslap.c@183
PS1, Line 183: #define PARSE_ERR(errmsg) \
> Not sure what the benefit for this macro is... […]
it allows me to not repeat "Decoding BSSLAP TA Response: " all over the place,
and that then again allows me to copy-paste parsing error messages from other _dec_ functions without forgetting to adjust the message type name as well.
Hm, duplicating ';', right.
https://gerrit.osmocom.org/c/libosmocore/+/20333/1/src/gsm/bsslap.c@458
PS1, Line 458: {}
> IIRC we had problems with this not finished in 0x00 and NULL? maybe some libosmocore linter?
no problems at all. I wrote verify_value_string_arrays_are_terminated.py myself
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20333
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6409c4bcac402dc7626a3afce9081c59cd715fe8
Gerrit-Change-Number: 20333
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Oct 2020 13:15:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/c03b4e43/attachment.htm>