This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373 ) Change subject: bsc: implement initial LCS tests for OsmoBSC ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373/1/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373/1/bsc/BSC_Tests.ttcn@4496 PS1, Line 4496: pri doesn't really look like a LCS related change? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373/1/bsc/BSC_Tests.ttcn@7537 PS1, Line 7537: rivate function f_match_bsslap(PDU_BSSAP_LE got_bsslap_msg, : template (present) BSSLAP_PDU expect_bsslap) : { : var BSSLAP_PDU bsslap := dec_BSSLAP_PDU(got_bsslap_msg.pdu.bssmap.co_info.bsslap_apdu.data); : if (not match(bsslap, expect_bsslap)) { : log("EXPECTING BSSLAP: ", expect_bsslap); : log("GOT BSSLAP: ", bsslap); : setverdict(fail, "BSSLAP is not as expected"); : mtc.stop; : } : setverdict(pass); : } looks like 'decmatch' to me? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373/1/bsc/BSC_Tests.ttcn@7555 PS1, Line 7555: ? you can put 'decmatch expect_rx_bsslap' here instead of the '?'. If you want to catch the non-matching case, you can use an alt {} statement with other (including wild-card) case to setverdict(fail). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373/1/bsc/BSC_Tests.ttcn@7565 PS1, Line 7565: f I would really want to avoid such function entry/exit statemtns in any programming language. Particularly as you can configure TTCN3 logger to produce function entry/exit log lines automatically, if so desired. And you can even constrain that log config to individual components. Maybe it would be time for a TITAN Logger plugin that emits GSMTAP? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id3df9439752c088cff5618d21254af42365690ca Gerrit-Change-Number: 20373 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Thu, 01 Oct 2020 11:58:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/abd13cd2/attachment.htm>