Change in libosmocore[master]: add BSSMAP coding for Location Services

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20335 )

Change subject: add BSSMAP coding for Location Services
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/20335/1/src/gsm/gsm0808.c 
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/c/libosmocore/+/20335/1/src/gsm/gsm0808.c@1363 
PS1, Line 1363: 	out = msgb_tl_put(msg, GSM0808_IE_IMSI);
              : 		rc = osmo_mobile_identity_encode_msgb(msg, &params->imsi, false);
              : 		if (rc < 0) {
              : 			msgb_free(msg);
              : 			return NULL;
              : 		}
              : 		/* write the MI value length */
              : 		*out = rc;
We are seeing this pattern across multiple patches here.  Why not simply have a "osmo_mobile_identity_encode_msgb_tlv(msg, iei, IMSI, false,)" function? This way you can save the temporary "out" variable, and the manual "lets write the length after encoding".

A better name might IMHO actually even be a msgb_tlv_put_mobile_identity().



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20335
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4d7302a4853518916b6b425e710c10568eb2ffe5
Gerrit-Change-Number: 20335
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 01 Oct 2020 10:12:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/7eb3e313/attachment.htm>