Change in osmo-bsc[master]: oml: encode IPv6 NSVC using the new OML attribute NM_ATT_OSMO_NS_LINK...

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20234 )

Change subject: oml: encode IPv6 NSVC using the new OML attribute NM_ATT_OSMO_NS_LINK_CFG
......................................................................


Patch Set 9: Code-Review-1

(9 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/include/osmocom/bsc/gsm_data.h 
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/include/osmocom/bsc/gsm_data.h@12 
PS9, Line 12: #include <osmocom/core/sockaddr_str.h>
This include is not needed AFAICT.


https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bsc_vty.c@775 
PS9, Line 775: 		osmo_sockaddr_str_to_sockaddr(&remote, &nsvc->remote.u.sas);
This should be osmo_sockaddr_str_from_sockaddr.


https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bsc_vty.c@776 
PS9, Line 776: 		if (nsvc->remote.u.sa.sa_family != AF_UNSPEC) {
Maybe if (osmo_sockaddr_str_is_set()) ?


https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bsc_vty.c@782 
PS9, Line 782: 		 * port can be even configured when when the IP isn't */
double when


https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bsc_vty.c@784 
PS9, Line 784: 			osmo_htons(nsvc->remote.u.sin.sin_port), VTY_NEWLINE);
osmo_sockaddr_port(&nsvc->remote) (and you can also remove the byteswap.h).


https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bsc_vty.c@3050 
PS9, Line 3050: 	switch (remote.af) {
Simply call osmo_sockaddr_str_to_sockaddr()


https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bts_ipaccess_nanobts.c 
File src/osmo-bsc/bts_ipaccess_nanobts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/bts_ipaccess_nanobts.c@230 
PS9, Line 230: 		if (osmo_bts_has_feature(&bts->features, BTS_FEAT_IPV6_NSVC) &&
if (!osmo_bts_has_feature


https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/pcu_sock.c 
File src/osmo-bsc/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/pcu_sock.c@196 
PS9, Line 196: 		info_ind->remote_port[i] = osmo_ntohs(nsvc->remote.u.sin.sin_port);
osmo_sockaddr_port()


https://gerrit.osmocom.org/c/osmo-bsc/+/20234/9/src/osmo-bsc/pcu_sock.c@197 
PS9, Line 197: 		info_ind->remote_ip[i] = osmo_ntohl(nsvc->remote.u.sin.sin_addr.s_addr);
So no IPv6 support here?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20234
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6529876a3c1116a79dd624312243d8ae48a41fe2
Gerrit-Change-Number: 20234
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Oct 2020 09:30:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/a04021c7/attachment.htm>