This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21376 ) Change subject: AMR start-mode auto: send smod bits as zero ...................................................................... AMR start-mode auto: send smod bits as zero When ICMI becomes zero for 'start-mode auto', the smod bits will remain whatever start-mode was set in the previous osmo-bsc config. Instead, osmo-bsc should clear the smod bits for 'start-mode auto' so that its MultiRate Config does not vary depending on what was previously configured. Change-Id: I1ec5bad0bce01cc425ee05ecf70c83ec662a226a --- M src/osmo-bsc/bsc_vty.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved dexter: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index 5022fe1..d8e9682 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -4199,9 +4199,10 @@ } } - if (argv[0][0] == 'a' || num == 0) + if (argv[0][0] == 'a' || num == 0) { mr_conf->icmi = 0; - else { + mr_conf->smod = 0; + } else { mr_conf->icmi = 1; if (num < atoi(argv[0])) mr_conf->smod = num - 1; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1ec5bad0bce01cc425ee05ecf70c83ec662a226a Gerrit-Change-Number: 21376 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201130/93d6852b/attachment.htm>