Change in osmo-ttcn3-hacks[master]: gbproxy: Test for sizes up to 1600 bytes, not just 1024 bytes

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21401 )

Change subject: gbproxy: Test for sizes up to 1600 bytes, not just 1024 bytes
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21401/1/gbproxy/GBProxy_Tests.ttcn 
File gbproxy/GBProxy_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21401/1/gbproxy/GBProxy_Tests.ttcn@788 
PS1, Line 788: 	for (i := 0; i < max_fr_info_size-4; i := i+4) {
> this should be max_fr_info_size + 4 afaiu. You want to test these 2 cases right: […]
no, I want tot test up to max_fr_info_size-4, as the 4 bytes header overhead is added by he NS layer, resulting in 1600 bytes "information field" to frame realy, which is what the spec says is required :)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21401
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I76358323e79cfc3d0e9c979c716b7a552f3b8e3b
Gerrit-Change-Number: 21401
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 30 Nov 2020 13:32:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201130/1ae8cb59/attachment.htm>