This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21329 ) Change subject: sched_lchan_tchh: fix frame number and fill FACCH gap ...................................................................... Patch Set 2: > Patch Set 1: > > > I was thinking about using struct l1sched_meas_set, but I was not sure if I should touch it. I also thought maybe using this then as a replacement for the remap functions too but this should be a follow up patch then. Ok, then I use struct l1sched_meas_set to keep track of the FN. > > The problem is that this is a 'hot' code part that is executed quite often, so we should avoid adding more buffers and syscalls. Your remap functions would still be useful, because in some cases the ring buffer may not contain some samples (e.g. right after the channel activation). I found a way to calculate the frame number from two bursts before. I have tested it and the results were the same as the ones I got before with the shift buffer. So we need no buffering at all now but I still use memset() and memcpy() to copy the measurement results around. I technically need only meas_avg.toa256 and meas_avg.rssi, so I could optimize this out, if necessary. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1ad9fa3815feb2b4da608ab7df716a87ba1f2f91 Gerrit-Change-Number: 21329 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Sun, 29 Nov 2020 20:38:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201129/f1a67dd7/attachment.htm>