This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21105 ) Change subject: l1sap: add repeated downlink SACCH ...................................................................... Patch Set 7: (4 comments) (ensure all comments are sent) https://gerrit.osmocom.org/c/osmo-bts/+/21105/5/include/osmo-bts/gsm_data.h File include/osmo-bts/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bts/+/21105/5/include/osmo-bts/gsm_data.h@267 PS5, Line 267: rep_sacch > Why do you add it to lchan->tch? Is 'Repeated SACCH' a TCH specific feature? No, it isn't. SACCH exists not only for TCH channels. I also took another look at the spec. I can't find any notes about a limitation to TCH channels. https://gerrit.osmocom.org/c/osmo-bts/+/21105/5/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/21105/5/src/common/l1sap.c@1007 PS5, Line 1007: > ws... Done https://gerrit.osmocom.org/c/osmo-bts/+/21105/5/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/21105/5/src/common/rsl.c@833 PS5, Line 833: if( > coding style Done https://gerrit.osmocom.org/c/osmo-bts/+/21105/6/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/21105/6/src/common/rsl.c@834 PS6, Line 834: if (lchan->rep_sacch) > +1, better if you rework this patch imho :) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00806f936b15fbaf6a4e7bbd61f3bec262cdbb28 Gerrit-Change-Number: 21105 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sat, 28 Nov 2020 21:45:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201128/1b076fde/attachment.htm>