Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: Send BssgpResetIndication when PTP BVC are being reset

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Nov 27 18:19:14 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21383 )

Change subject: BSSGP_Emulation: Send BssgpResetIndication when PTP BVC are being reset
......................................................................

BSSGP_Emulation: Send BssgpResetIndication when PTP BVC are being reset

This notifies the user via the MGMT port about the fact that an inbound
BVC-RESET procedure just happened.

Change-Id: I54d0d5e0e06a330a90dfb1da06062d65022efe81
---
M gbproxy/GBProxy_Tests.ttcn
M library/BSSGP_Emulation.ttcnpp
2 files changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn
index df32174..78eb389 100644
--- a/gbproxy/GBProxy_Tests.ttcn
+++ b/gbproxy/GBProxy_Tests.ttcn
@@ -384,6 +384,9 @@
 	[] SGSN_MGMT.receive(BssgpStatusIndication:{*, ?, ?}) {
 		repeat;
 		}
+	[] SGSN_MGMT.receive(BssgpResetIndication:?) {
+		repeat;
+		}
 	[] SGSN_MGMT.receive {
 		setverdict(fail, "Received unexpected message on SGSN_MGMT");
 		mtc.stop;
diff --git a/library/BSSGP_Emulation.ttcnpp b/library/BSSGP_Emulation.ttcnpp
index 2fa588b..c39adaa 100644
--- a/library/BSSGP_Emulation.ttcnpp
+++ b/library/BSSGP_Emulation.ttcnpp
@@ -1157,6 +1157,9 @@
 	/* we are a SGSN: BSS/PCU-originated RESET must have a cell ID */
 	[g_sgsn_role] BVC.receive(tr_ptp_BnsUdInd(tr_BVC_RESET(?, g_cfg.bvci, g_cfg.cell_id), 0)) -> value udi {
 		log("Rx BVC-RESET from BVCI=", g_cfg.bvci);
+		if (MGMT.checkstate("Connected")) {
+			MGMT.send(BssgpResetIndication:{g_cfg.bvci});
+		}
 		/* Respond to RESET with correct BVCI but without CellID */
 		BVC.send(ts_ptp_BnsUdReq(ts_BVC_RESET_ACK(g_cfg.bvci, omit), 0, g_bvc_lsp));
 		/* FIXME: reset all state? What about clients? */
@@ -1165,6 +1168,9 @@
 	/* we are a BSS/PCU: SGSN-originated RESET must not have a cell ID */
 	[not g_sgsn_role] BVC.receive(tr_ptp_BnsUdInd(tr_BVC_RESET(?, g_cfg.bvci, omit), 0)) -> value udi {
 		log("Rx BVC-RESET from BVCI=", g_cfg.bvci);
+		if (MGMT.checkstate("Connected")) {
+			MGMT.send(BssgpResetIndication:{g_cfg.bvci});
+		}
 		/* Respond to RESET with correct BVCI with CellID */
 		BVC.send(ts_ptp_BnsUdReq(ts_BVC_RESET_ACK(g_cfg.bvci, g_cfg.cell_id), 0, g_bvc_lsp));
 		/* FIXME: reset all state? What about clients? */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21383
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I54d0d5e0e06a330a90dfb1da06062d65022efe81
Gerrit-Change-Number: 21383
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201127/e7225a9e/attachment.htm>


More information about the gerrit-log mailing list