This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/21384 ) Change subject: mgcp_trunk: get rid of magic numbers for E1 slots ...................................................................... Patch Set 2: (1 comment) (making sure that all comments are sent) https://gerrit.osmocom.org/c/osmo-mgw/+/21384/1/include/osmocom/mgcp/mgcp_trunk.h File include/osmocom/mgcp/mgcp_trunk.h: https://gerrit.osmocom.org/c/osmo-mgw/+/21384/1/include/osmocom/mgcp/mgcp_trunk.h@63 PS1, Line 63: bool ts_in_use[NUM_E1_TS-1]; > would be interesting to know why the -1 This is indeed not obvious. I have added a comment. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/21384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I1cf5fa17f7455448a08ec3c32febca450eadb21e Gerrit-Change-Number: 21384 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 27 Nov 2020 14:18:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201127/141f7d5e/attachment.htm>