Change in libosmocore[master]: frame_relay: Fix error path on ioctl() failure

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Nov 26 08:32:30 UTC 2020


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/21378 )


Change subject: frame_relay: Fix error path on ioctl() failure
......................................................................

frame_relay: Fix error path on ioctl() failure

We don't want to pass -EINVAL as file descriptor into the bind() call.

Closes: CID#215529
Change-Id: Ic4d411c0ade6867c4fe2c01eb3368e6420158724
---
M src/gb/gprs_ns2_fr.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/78/21378/1

diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c
index 80e3366..d0ff010 100644
--- a/src/gb/gprs_ns2_fr.c
+++ b/src/gb/gprs_ns2_fr.c
@@ -320,6 +320,7 @@
 			strerror(errno));
 		close(fd);
 		fd = -EINVAL;
+		return fd;
 	}
 
 	rc = bind(fd, (struct sockaddr *)&addr, sizeof(addr));

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21378
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic4d411c0ade6867c4fe2c01eb3368e6420158724
Gerrit-Change-Number: 21378
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201126/a2229501/attachment.htm>


More information about the gerrit-log mailing list