Change in osmo-bts[master]: sched_lchan_tchh: fix frame number and fill FACCH gap

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Wed Nov 25 22:34:52 UTC 2020


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21329 )

Change subject: sched_lchan_tchh: fix frame number and fill FACCH gap
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Nice catch!
> 
> I think there is a simpler way to get the correct frame numbers.
> 
> We already have ring buffers for the measurements, right? We can abuse them a bit by adding TDMA frame number field to 'struct l1sched_meas_set', so you would be able to get frame number of the first burst without the need to do remapping and adding additional ring buffers.
> 
> This is already implemented in trxcon. What do you think?

I was thinking about using struct l1sched_meas_set, but I was not sure if I should touch it. I also thought maybe using this then as a replacement for the remap functions too but this should be a follow up patch then. Ok, then I use struct l1sched_meas_set to keep track of the FN.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21329
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1ad9fa3815feb2b4da608ab7df716a87ba1f2f91
Gerrit-Change-Number: 21329
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Nov 2020 22:34:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201125/976fc426/attachment.htm>


More information about the gerrit-log mailing list