Change in osmo-gsm-tester[master]: Introduce Android UEs as new modems

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Nov 25 15:02:22 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302 )

Change subject: Introduce Android UEs as new modems
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2//COMMIT_MSG@87 
PS2, Line 87:   ue_serial: '8d9d79a9'
> This is the USB serial of the device used by ADB to identify UEs. […]
Thanks, not mandatory but we have one field name to care about then (which is great because we have many).


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2/src/osmo_gsm_tester/obj/bitrate_monitor.py 
File src/osmo_gsm_tester/obj/bitrate_monitor.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2/src/osmo_gsm_tester/obj/bitrate_monitor.py@58 
PS2, Line 58:             self.rem_host.remote_user = 'root'
> Unfortunately sudo is not available under Android and we did not find a way to add users to the Andr […]
ACK, but then why not simply setting "root" as ssh_user in resources.conf for this MS?


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2/sysmocom/suites/4g/iperf3_dl.py 
File sysmocom/suites/4g/iperf3_dl.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2/sysmocom/suites/4g/iperf3_dl.py@26 
PS2, Line 26: proc = iperf3cli.prepare_test_proc(iperf3cli.DIR_DL, ue.netns(), bitrate=max_rate, ue=ue)
> In case an AndroidUE is used I need to know two values, the ADB serial of the UE for local execution […]
What about extending RunNode with a new "run_type" = "adb" and then add a new schema property "adb_serial_id" to it?

This way inside iperf3cli.prepare_test_proc you can check for run_node.run_type() == "adb" and then gather the serial id with run_node.adb_serial_id().

You could even reuse the "run_addr" in this case, I think it makes sense (unless you also need to use/configure an IPv4 address too).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I79a5d803e869a868d4dac5e0d4c2feb38038dc5c
Gerrit-Change-Number: 21302
Gerrit-PatchSet: 2
Gerrit-Owner: ninjab3s <nils.fuerste at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Nov 2020 15:02:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ninjab3s <nils.fuerste at softwareradiosystems.com>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201125/5e063f00/attachment.htm>


More information about the gerrit-log mailing list