Change in libosmo-abis[master]: ipaccess: Fix wrong assertion in ipaccess_drop() when used by BTS code

[pespin]

Hello Jenkins Builder, fixeria, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/libosmo-abis/+/21282

to look at the new patch set (#2).

Change subject: ipaccess: Fix wrong assertion in ipaccess_drop() when used by BTS code
......................................................................

ipaccess: Fix wrong assertion in ipaccess_drop() when used by BTS code

The code wrongly assumed that ipaccess_drop was only called by BSC code,
which is wrong. ipaccess_drop is called by BTS run code path in __handle_ts1_write(),
if send() syscall fails (for instance because BSC becomes unreachable).
In that case, we need to account for the BTS role case which doesn't
store the line pointer into the ofd->data. In BTS case, it's a pointer
to the struct ipa_client_conn, which we leave up to sign_link_down() cb
to do whatever they please with.

Fixes: OS#4864
Change-Id: If763e5f7736921a4360ad9027ba075ef8e118934
---
M src/input/ipaccess.c
1 file changed, 17 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/82/21282/2
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/21282
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: If763e5f7736921a4360ad9027ba075ef8e118934
Gerrit-Change-Number: 21282
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201124/64c71c04/attachment.htm>