Change in libosmocore[master]: ns2: implement link sharing selector

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Nov 24 02:37:08 UTC 2020


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21244 )

Change subject: ns2: implement link sharing selector
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/21244/1/src/gb/gprs_ns2.c 
File src/gb/gprs_ns2.c:

https://gerrit.osmocom.org/c/libosmocore/+/21244/1/src/gb/gprs_ns2.c@a62 
PS1, Line 62:  * - Only UDP is supported as of now, no frame relay support
> This line should actually be dropped in previous patch right?
Ack


https://gerrit.osmocom.org/c/libosmocore/+/21244/1/src/gb/gprs_ns2.c@309 
PS1, Line 309: 		struct gprs_ns2_nse *nse)
> this looks weird, move it to same line better.
Ack


https://gerrit.osmocom.org/c/libosmocore/+/21244/1/src/gb/gprs_ns2.c@400 
PS1, Line 400: 		nsvc = llist_first_entry(&nse->nsvc, struct gprs_ns2_vc, list);
> see the llist_empty() check above.  If it is empty, we wouldn't get here.
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21244
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I212fa1a65e8c16cf1e525d1962d5689446c7e49e
Gerrit-Change-Number: 21244
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 24 Nov 2020 02:37:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201124/861d7eb6/attachment.htm>


More information about the gerrit-log mailing list