Change in osmo-pcu[master]: pdch: packet_paging_request: Put back non-fitting paging entry where ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Nov 23 15:06:00 UTC 2020


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21303 )


Change subject: pdch: packet_paging_request: Put back non-fitting paging entry where where it was
......................................................................

pdch: packet_paging_request: Put back non-fitting paging entry where where it was

dequeue_paging() dequeues the first paging (at the start of the list).
If a paging request is dequeued but later it cannot be added to the
message being sent, it has to be re-added to the list for later
processing on next message. However, existing code was enqueueing it at
the end, which meant that paging request was delayed for no reason.

Change-Id: Iad8e7045267d56e32f42db0fbb8448b1b1185f05
---
M src/pdch.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/03/21303/1

diff --git a/src/pdch.cpp b/src/pdch.cpp
index a7dd2aa..dc98877 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -235,7 +235,7 @@
 			LOGP(DRLCMAC, LOGL_DEBUG, "- Does not fit, so schedule "
 				"next time\n");
 			/* put back paging record, because does not fit */
-			llist_add_tail(&pag->list, &paging_list);
+			llist_add(&pag->list, &paging_list);
 			break;
 		}
 		Encoding::write_repeated_page_info(pag_vec, wp, pag->identity_lv[0],

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21303
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iad8e7045267d56e32f42db0fbb8448b1b1185f05
Gerrit-Change-Number: 21303
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201123/1854f527/attachment.htm>


More information about the gerrit-log mailing list