Change in osmo-gsm-tester[master]: ms_amarisoft: fix various regressions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Nov 20 12:30:14 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21258 )

Change subject: ms_amarisoft: fix various regressions
......................................................................


Patch Set 2: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21258/2/src/osmo_gsm_tester/obj/ms.py 
File src/osmo_gsm_tester/obj/ms.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21258/2/src/osmo_gsm_tester/obj/ms.py@40 
PS2, Line 40:         'count': schema.UINT
I'd like to implement this in a different way in the future. Have 1 ms object for each amarisoft virtual UE, and somehow plug them together in the class implementation to configure and run the same amarisoftue process.


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21258/2/src/osmo_gsm_tester/obj/ms.py@134 
PS2, Line 134:     def features(self):
Can you please make sure this is also defined as @abstractmethod in ms.py base class? (here or another patch I don't mind).


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21258/2/src/osmo_gsm_tester/obj/ms_amarisoft.py 
File src/osmo_gsm_tester/obj/ms_amarisoft.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21258/2/src/osmo_gsm_tester/obj/ms_amarisoft.py@35 
PS2, Line 35:         'license_server_addr': schema.IPV4
is this comma really an issue?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21258
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I397e675a4018acf3372a3b7e29fd864703b2b919
Gerrit-Change-Number: 21258
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Nov 2020 12:30:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201120/b14935e9/attachment.htm>


More information about the gerrit-log mailing list