This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21245 ) Change subject: ns2: permit multiple nsvci in one nse in VTY ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21245/1/src/gb/gprs_ns2_vty.c File src/gb/gprs_ns2_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/21245/1/src/gb/gprs_ns2_vty.c@170 PS1, Line 170: > does it hurt? is it worth commenting on it? I don't mind an extra empty line here or there, as long […] Well this new line is not really related to this patch in any way, since there's no modification in immediate lines above or below. And I would say in general we all tend to leave only 1 empty lines between functions. So it's making the patch larger for no reason and still adding a space which imho makes no sense here. But I understand this code is in early versions so if you want to speed up simply merge it. In any case fixing this requires a few seconds, and still other patches has issues that need to be solved. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4ad454320d0a03e81b399f55e8bd0ee57402dad0 Gerrit-Change-Number: 21245 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 20 Nov 2020 12:17:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge at osmocom.org> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201120/c20b0dc0/attachment.htm>