This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21014 ) Change subject: l1sap: add repeated downlink FACCH ...................................................................... Patch Set 9: (4 comments) Mostly cosmetic warnings, looks good in general. https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/l1sap.c@973 PS9, Line 973: uint8_t const https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/l1sap.c@974 PS9, Line 974: int size_t or unsigned int, it cannot be negative https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/l1sap.c@976 PS9, Line 976: meas_res const https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/rsl.c@832 PS9, Line 832: memset Is memset() really needed here? For just two pointers, setting to NULL makes more sense. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I72f0cf7eaaef9f80fc35e752c90ae0e2d24d0c75 Gerrit-Change-Number: 21014 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Thu, 19 Nov 2020 17:47:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201119/d79b769c/attachment.htm>