Change in libosmocore[master]: ns2: Split initiater into init_reset and init_block

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21240 )

Change subject: ns2: Split initiater into init_reset and init_block
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/21240/1/src/gb/gprs_ns2_vc_fsm.c 
File src/gb/gprs_ns2_vc_fsm.c:

https://gerrit.osmocom.org/c/libosmocore/+/21240/1/src/gb/gprs_ns2_vc_fsm.c@60 
PS1, Line 60: bool init_block;
            : 	bool init_reset;
it's nice that the comment above now describes an 'initiator' variable that doesn't exist anymore.  Either change the comment or rename the variables.  I would say initiate_resest / initiate_block mgiht also do a good job?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21240
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iff5aff0cf8d19d9c718dd11c4e731ced2aeb16ba
Gerrit-Change-Number: 21240
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Thu, 19 Nov 2020 17:31:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201119/b4fc314d/attachment.htm>