Change in osmo-bts[master]: l1sap: add repeated uplink SACCH

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21185 )

Change subject: l1sap: add repeated uplink SACCH
......................................................................


Patch Set 2:

(3 comments)

This change is ready for review.

https://gerrit.osmocom.org/c/osmo-bts/+/21185/1/src/osmo-bts-trx/sched_lchan_xcch.c 
File src/osmo-bts-trx/sched_lchan_xcch.c:

https://gerrit.osmocom.org/c/osmo-bts/+/21185/1/src/osmo-bts-trx/sched_lchan_xcch.c@73 
PS1, Line 73: 	if (chan == TRXC_SACCHTF || chan == TRXC_SACCHTH_0 || chan ==TRXC_SACCHTH_1)
> This is not going to work for SDCCH, only for TCH. Here is a more universal approach: […]
Done


https://gerrit.osmocom.org/c/osmo-bts/+/21185/1/src/osmo-bts-trx/sched_lchan_xcch.c@91 
PS1, Line 91: UL-SACCH requires additional memory
> ... but only if repeation is enabled, right? Not unconditionally.
Done


https://gerrit.osmocom.org/c/osmo-bts/+/21185/1/src/osmo-bts-trx/sched_lchan_xcch.c@161 
PS1, Line 161: l2_len = 0
> It's already set to 0 above.
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21185
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7e4cc33cc010866e41e3b594351a7f7bf93e08ac
Gerrit-Change-Number: 21185
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 19 Nov 2020 14:58:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201119/aae38abb/attachment.htm>