Change in osmo-bsc[master]: abis_rsl: parse cm3 and indicate ACCH repetition cap to BTS

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21084 )

Change subject: abis_rsl: parse cm3 and indicate ACCH repetition cap to BTS
......................................................................


Patch Set 8:

(6 comments)

thanks for your review!

https://gerrit.osmocom.org/c/osmo-bsc/+/21084/4/src/osmo-bsc/abis_rsl.c 
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21084/4/src/osmo-bsc/abis_rsl.c@476 
PS4, Line 476: 	if (!(bts->model->type == GSM_BTS_TYPE_OSMOBTS
> Remove BTS type and simply check for the feature.
What happens if we have a different BTS vendor that also has BTS_FEAT_ACCH_REP, but implemented differently?


https://gerrit.osmocom.org/c/osmo-bsc/+/21084/7/src/osmo-bsc/abis_rsl.c 
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21084/7/src/osmo-bsc/abis_rsl.c@462 
PS7, Line 462: static void put_rsl_ie_osmo_rep_acch_cap(struct gsm_lchan *lchan,
> (function name reads like it always puts an RSL IE in a msgb, but it first decides on whether that s […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/21084/7/src/osmo-bsc/abis_rsl.c@468 
PS7, Line 468: if (!lchan->conn)
             : 		return;
             : 
             : 	bts = conn_get_bts(lchan->conn);
             : 	OSMO_ASSERT(bts);
> instead of all this, just say […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/21084/7/src/osmo-bsc/abis_rsl.c@494 
PS7, Line 494: 	msgb_tlv_put(msg, RSL_IE_OSMO_REP_ACCH_CAP, sizeof(cap),
> I think it should be possible to avoid allocating this structure on stack and then copying it over t […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/21084/7/src/osmo-bsc/abis_rsl.c@495 
PS7, Line 495: 		     (uint8_t *) & cap);
> (unusual spaces)
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/21084/4/src/osmo-bsc/gsm_08_08.c 
File src/osmo-bsc/gsm_08_08.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21084/4/src/osmo-bsc/gsm_08_08.c@613 
PS4, Line 613: 			conn->repeated_acch_capability = true;
> As stated I'd put the "struct gsm48_classmark3" cm3 field inside conn struct and simply pass it to g […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21084
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I39ae439d05562b35b2e47774dc92f8789fea1a57
Gerrit-Change-Number: 21084
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 19 Nov 2020 11:45:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201119/6befae66/attachment.htm>