This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/21239 ) Change subject: common: Introduce OSMOCOM_REPO_MIRROR param ...................................................................... Patch Set 1: > Patch Set 1: > > wouldnt it have made sense to specify a default value for the variable, so that building withou tany explicit build-arg still works? The default value is in Makefile.am, so if you build with make it works out of the box. Default value in Dockerfile is only needed if one attempts to build directly from it. I can add it to each Dockerfile if you prefer, but I thought it was going to be confusing since anyway that value is not used because a default value is pssed through Makefile. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/21239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8010b08f3dabacfb3c13a44eece6c7a490e0742e Gerrit-Change-Number: 21239 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Wed, 18 Nov 2020 21:02:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201118/a92148de/attachment.htm>