This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21201 ) Change subject: handover test: add test 30: de-congest TCH/F by moving to dyn TS TCH/H ...................................................................... handover test: add test 30: de-congest TCH/F by moving to dyn TS TCH/H In the test, show the undesired behavior of moving non-dynamic timeslots first, because they are the first to be considered in the congestion resolution loop. The behavior will be fixed in Ic221b8d2687cdec0bf94410c84a4da43853f0900. Change-Id: I09ab9f2f79fa434c7279cb4d09899f69b047aa55 --- M tests/handover/handover_test.c M tests/testsuite.at 2 files changed, 46 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c index d442d99..46f7cb8 100644 --- a/tests/handover/handover_test.c +++ b/tests/handover/handover_test.c @@ -1655,6 +1655,45 @@ NULL }; +static char *test_case_30[] = { + "2", + + "Congestion check: Balancing congestion by handover TCH/F -> TCH/H\n\n" + "With dynamic timeslots.\n" + "As soon as only one TCH/F is left, there should be HO to a dyn TS.\n" + , + "create-bts", "1", "c+s4", "TCH/F", "TCH/F", "TCH/F", "dyn", "dyn", "dyn", "PDCH", + "set-min-free", "0", "TCH/F", "2", + "set-min-free", "0", "TCH/H", "0", + "as-enable", "0", "1", + "set-ts-use", "0", "0", "*", "TCH/F", "TCH/F", "TCH/F", "TCH/F", "PDCH", "PDCH", "PDCH", + "meas-rep", "0","0","1","0", "40","0", "1", "0","30", + "meas-rep", "0","0","2","0", "40","0", "1", "0","30", + "meas-rep", "0","0","3","0", "40","0", "1", "0","30", + "meas-rep", "0","0","4","0", "40","0", "1", "0","30", + "congestion-check", + "expect-no-chan", + "create-ms", "0", "TCH/F", "AMR", + "meas-rep", "0","0","5","0", "40","0", "1", "0","30", + "expect-ts-use", "0", "0", "*", "TCH/F", "TCH/F", "TCH/F", "TCH/F", "TCH/F", "PDCH", "PDCH", + "congestion-check", + "expect-chan", "0", "6", + "ack-chan", + /* Not so good: rather than moving static TCH/F, we should favor freeing dyn TS, for more PDCH */ + "expect-ho", "0", "1", + "ho-complete", + "expect-ts-use", "0", "0", "*", "-", "TCH/F", "TCH/F", "TCH/F", "TCH/F", "TCH/H-", "PDCH", + "congestion-check", + "expect-chan", "0", "6", + "ack-chan", + "expect-ho", "0", "2", + "ho-complete", + "expect-ts-use", "0", "0", "*", "-", "-", "TCH/F", "TCH/F", "TCH/F", "TCH/HH", "PDCH", + "congestion-check", + "expect-no-chan", + NULL +}; + static char **test_cases[] = { test_case_0, @@ -1687,6 +1726,7 @@ test_case_27, test_case_28, test_case_29, + test_case_30, }; static const struct log_info_cat log_categories[] = { diff --git a/tests/testsuite.at b/tests/testsuite.at index a0d85ce..787f33d 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -230,3 +230,9 @@ cat $abs_srcdir/handover/handover_test.ok > expout AT_CHECK([$abs_top_builddir/tests/handover/handover_test 29], [], [expout], [ignore]) AT_CLEANUP + +AT_SETUP([handover test 30]) +AT_KEYWORDS([handover]) +cat $abs_srcdir/handover/handover_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/handover/handover_test 30], [], [expout], [ignore]) +AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21201 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I09ab9f2f79fa434c7279cb4d09899f69b047aa55 Gerrit-Change-Number: 21201 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201117/e181f788/attachment.htm>