Change in osmo-pcu[master]: decoding: Fix implicit ACK due to BeginOfWindow=1 on rx EGPRS PKT DL ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Nov 16 19:38:11 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21122 )

Change subject: decoding: Fix implicit ACK due to BeginOfWindow=1 on rx EGPRS PKT DL ACK/NACK
......................................................................


Patch Set 3:

Frankly speaking, some abbreviations mentioned in the commit message are not (yet) known to me. Thus I cannot check if this calculation was/is absolutely correct.  But existence of a TTCN-3 test case, and your observations convinced me enough to give CR+1 ;)


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21122
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ic71326fc956491bb7e5e50896a6ba8f5354c20ec
Gerrit-Change-Number: 21122
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Mon, 16 Nov 2020 19:38:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201116/5c8dc93c/attachment.htm>


More information about the gerrit-log mailing list