Change in osmo-bsc[master]: abis_rsl: parse cm3 and indicate ACCH repetition cap to BTS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Nov 16 09:33:11 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21084 )

Change subject: abis_rsl: parse cm3 and indicate ACCH repetition cap to BTS
......................................................................


Patch Set 4:

(2 comments)

I'm wondering whether it would make more sense to simply parse cm3 inside osmo-bts and apply whatever is needed directly in there instead of doing it in osmo-bsc, given there's no standard way to notify this information in Abis.

https://gerrit.osmocom.org/c/osmo-bsc/+/21084/4/src/osmo-bsc/abis_rsl.c 
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21084/4/src/osmo-bsc/abis_rsl.c@476 
PS4, Line 476: 	if (!(bts->model->type == GSM_BTS_TYPE_OSMOBTS
Remove BTS type and simply check for the feature.


https://gerrit.osmocom.org/c/osmo-bsc/+/21084/4/src/osmo-bsc/gsm_08_08.c 
File src/osmo-bsc/gsm_08_08.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21084/4/src/osmo-bsc/gsm_08_08.c@613 
PS4, Line 613: 			conn->repeated_acch_capability = true;
As stated I'd put the "struct gsm48_classmark3" cm3 field inside conn struct and simply pass it to gsm48_decode_classmark3 above, then you don't need this extra field.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21084
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I39ae439d05562b35b2e47774dc92f8789fea1a57
Gerrit-Change-Number: 21084
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Nov 2020 09:33:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201116/cea1f8d8/attachment.htm>


More information about the gerrit-log mailing list