Change in osmo-ttcn3-hacks[master]: pcu: Implement ACKing EGPRS Dl TBF blocks

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun Nov 15 08:54:10 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21127 )

Change subject: pcu: Implement ACKing EGPRS Dl TBF blocks
......................................................................


Patch Set 3:

(4 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21127/3/library/RLCMAC_Templates.ttcn 
File library/RLCMAC_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21127/3/library/RLCMAC_Templates.ttcn@364 
PS3, Line 364: template
Let's make sure to always add proper template restrictions, "(omit)" in this case.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21127/3/library/RLCMAC_Templates.ttcn@373 
PS3, Line 373: template 
Same here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21127/3/library/RLCMAC_Templates.ttcn@397 
PS3, Line 397: template
And here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21127/3/pcu/GPRS_Components.ttcn 
File pcu/GPRS_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21127/3/pcu/GPRS_Components.ttcn@127 
PS3, Line 127: 0000000000000000000000000000000000000000000000000000000000000000
You could use f_pad_bit(), but not critical.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21127
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9f1b621a8365e69d2e1a33d59cb8c7a59639ad94
Gerrit-Change-Number: 21127
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Sun, 15 Nov 2020 08:54:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201115/95aafcce/attachment.htm>


More information about the gerrit-log mailing list