Change in libosmo-abis[master]: Configure E1 pcap file per line

[keith]

keith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/21118 )

Change subject: Configure E1 pcap file per line
......................................................................


Patch Set 4:

(6 comments)

https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/include/osmocom/abis/e1_input.h 
File include/osmocom/abis/e1_input.h:

https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/include/osmocom/abis/e1_input.h@319 
PS3, Line 319: int e1_set_pcap_fd(int fd, int e1_nr);
> this is breaking API, are we fine with it? Was this API already released?
How is this done otherwise? A whole new version of the function?

int e1_set_pcap_fd_bynr(int fd, int e1_nr);

or something?


https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input.c 
File src/e1_input.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input.c@186 
PS3, Line 186: 			      struct msgb *msg, int pcap_fd) {
> this pcap_fd is not used?
Um.. yes.., no?

AFAIU it's used right below this comment and the last four lines of this function
by write()


https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input.c@901 
PS3, Line 901: 		if (line->pcap_fd)
> >= 0
Done


https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input_vty.c 
File src/e1_input_vty.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input_vty.c@248 
PS3, Line 248: DEFUN_ATTR(cfg_e1_pcap, cfg_e1_pcap_cmd,
> Rather update function names to be cfg_e1line_*
Done


https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input_vty.c@266 
PS3, Line 266: 		vty_out(vty, "Failed to setup E1 pcap recording to %s.%s", argv[1], VTY_NEWLINE);
> You can remove the dot at the end here and the string below.
Done


https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input_vty.c@279 
PS3, Line 279: 	line->pcap_file = talloc_strdup(line, argv[1]);
> osmo_talloc_replace_string
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/21118
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I316c3d6a839e84c2f52a148c6b8dd6f5933cf4bf
Gerrit-Change-Number: 21118
Gerrit-PatchSet: 4
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 13 Nov 2020 01:18:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201113/12f91dea/attachment.htm>