Change in libosmo-abis[master]: Include vty command 'pcap' in vty output

[keith]

keith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/21118 )

Change subject: Include vty command 'pcap' in vty output
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/libosmo-abis/+/21118/1/include/osmocom/abis/e1_input.h 
File include/osmocom/abis/e1_input.h:

https://gerrit.osmocom.org/c/libosmo-abis/+/21118/1/include/osmocom/abis/e1_input.h@197 
PS1, Line 197: 	char *pcap_file;
I put this here because I do not know how to handle a single "global" variable
with talloc, that is, outside of this e1inp_line struct. :-/ :-(
I did not find an example of such a thing in other vtys.

I see two ways to go forward, either implement the command as

pcap <0-255> .FILE 

and actually have per line pcaps, or learn how to have a global talloc
var outside the struct.


https://gerrit.osmocom.org/c/libosmo-abis/+/21118/1/src/e1_input_vty.c 
File src/e1_input_vty.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/21118/1/src/e1_input_vty.c@255 
PS1, Line 255: 	int e1_nr = 0;
WIP, Storing the variable on the line struct, see my other comment.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/21118
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I316c3d6a839e84c2f52a148c6b8dd6f5933cf4bf
Gerrit-Change-Number: 21118
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Comment-Date: Thu, 12 Nov 2020 06:07:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201112/1c2dfef1/attachment.htm>