Change in osmocom-bb[master]: Use osmo_fd_*_{disable,enable}

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Nov 11 20:14:45 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/20767 )

Change subject: Use osmo_fd_*_{disable,enable}
......................................................................

Use osmo_fd_*_{disable,enable}

Change-Id: I65d37821873767e61a7eca029f9b30938a299683
Depends: libosmocore.git Idb89ba7bc7c129a6304a76900d17f47daf54d17d
---
M src/host/osmocon/osmocon.c
1 file changed, 14 insertions(+), 14 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c
index 66b2ea0..d49c3fd 100644
--- a/src/host/osmocon/osmocon.c
+++ b/src/host/osmocon/osmocon.c
@@ -500,7 +500,7 @@
 	dnload.block_ptr = dnload.block;
 
 	dnload.block_number++;
-	dnload.serial_fd.when = OSMO_FD_READ | OSMO_FD_WRITE;
+	osmo_fd_update_when(&dnload.serial_fd, 0, OSMO_FD_READ | OSMO_FD_WRITE);
 	return 0;
 }
 
@@ -586,7 +586,7 @@
 		printf("Progress: %i%%\r", progress);
 		fflush(stdout);
 		dnload.write_ptr = dnload.data;
-		dnload.serial_fd.when &= ~OSMO_FD_WRITE;
+		osmo_fd_write_disable(&dnload.serial_fd);
 		if (dnload.romload_state == SENDING_LAST_BLOCK) {
 			dnload.romload_state = LAST_BLOCK_SENT;
 			printf("Finished, sent %i blocks in total\n",
@@ -638,7 +638,7 @@
 	} else if (dnload.write_ptr >= dnload.data + dnload.data_len) { 
 		printf("finished\n");
 		dnload.write_ptr = dnload.data;
-		dnload.serial_fd.when &= ~OSMO_FD_WRITE;
+		osmo_fd_write_disable(&dnload.serial_fd);
 		return 1;
 	}
 
@@ -682,7 +682,7 @@
 	}
 
 	if (end)
-		dnload.serial_fd.when &= ~OSMO_FD_WRITE;
+		osmo_fd_write_disable(&dnload.serial_fd);
 
 	return 0;
 }
@@ -751,7 +751,7 @@
 
 	sercomm_sendmsg(dlci, msg);
 
-	dnload.serial_fd.when |= OSMO_FD_WRITE;
+	osmo_fd_write_enable(&dnload.serial_fd);
 }
 
 static void hdlc_console_cb(uint8_t dlci, struct msgb *msg)
@@ -842,12 +842,12 @@
 		}
 	} else if (!memcmp(buffer, phone_prompt2, sizeof(phone_prompt2))) {
 		printf("Received PROMPT2 from phone, starting download\n");
-		dnload.serial_fd.when = OSMO_FD_READ | OSMO_FD_WRITE;
+		osmo_fd_update_when(&dnload.serial_fd, 0, OSMO_FD_READ | OSMO_FD_WRITE);
 		dnload.state = DOWNLOADING;
 	} else if (!memcmp(buffer, phone_ack, sizeof(phone_ack))) {
 		printf("Received DOWNLOAD ACK from phone, your code is"
 			" running now!\n");
-		dnload.serial_fd.when = OSMO_FD_READ;
+		osmo_fd_update_when(&dnload.serial_fd, 0, OSMO_FD_READ);
 		dnload.state = WAITING_PROMPT1;
 		dnload.write_ptr = dnload.data;
 		dnload.expect_hdlc = 1;
@@ -868,18 +868,18 @@
 	} else if (!memcmp(buffer, phone_nack, sizeof(phone_nack))) {
 		printf("Received DOWNLOAD NACK from phone, something went"
 			" wrong :(\n");
-		dnload.serial_fd.when = OSMO_FD_READ;
+		osmo_fd_update_when(&dnload.serial_fd, 0, OSMO_FD_READ);
 		dnload.state = WAITING_PROMPT1;
 		dnload.write_ptr = dnload.data;
 	} else if (!memcmp(buffer, phone_nack_magic, sizeof(phone_nack_magic))) {
 		printf("Received MAGIC NACK from phone, you need to"
 			" have \"1003\" at 0x803ce0\n");
-		dnload.serial_fd.when = OSMO_FD_READ;
+		osmo_fd_update_when(&dnload.serial_fd, 0, OSMO_FD_READ);
 		dnload.state = WAITING_PROMPT1;
 		dnload.write_ptr = dnload.data;
 	} else if (!memcmp(buffer, ftmtool, sizeof(ftmtool))) {
 		printf("Received FTMTOOL from phone, ramloader has aborted\n");
-		dnload.serial_fd.when = OSMO_FD_READ;
+		osmo_fd_update_when(&dnload.serial_fd, 0, OSMO_FD_READ);
 		dnload.state = WAITING_PROMPT1;
 		dnload.write_ptr = dnload.data;
 	}
@@ -1000,7 +1000,7 @@
 		if (!memcmp(buffer, romload_branch_ack,
 			    sizeof(romload_branch_ack))) {
 			printf("Received branch ack, your code is running now!\n");
-			dnload.serial_fd.when = OSMO_FD_READ;
+			osmo_fd_update_when(&dnload.serial_fd, 0, OSMO_FD_READ);
 			dnload.romload_state = FINISHED;
 			dnload.write_ptr = dnload.data;
 			dnload.expect_hdlc = 1;
@@ -1116,7 +1116,7 @@
 		printf("Received size ack\n");
 		dnload.expect_hdlc = 1;
 		dnload.mtk_state = MTK_SENDING_BLOCKS;
-		dnload.serial_fd.when = OSMO_FD_READ | OSMO_FD_WRITE;
+		osmo_fd_update_when(&dnload.serial_fd, 0, OSMO_FD_READ | OSMO_FD_WRITE);
 		bufptr -= 3;
 		break;
 	case MTK_SENDING_BLOCKS:
@@ -1138,7 +1138,7 @@
 			printf("Received Block %i preparing next block\n",
 				dnload.block_number);
 			mtk_prepare_block();
-			dnload.serial_fd.when = OSMO_FD_READ | OSMO_FD_WRITE;
+			osmo_fd_update_when(&dnload.serial_fd, 0, OSMO_FD_READ | OSMO_FD_WRITE);
 		}
 		break;
 	case MTK_WAIT_BRANCH_CMD_ACK:
@@ -1156,7 +1156,7 @@
 			break;
 		printf("Received branch address ack, code should run now\n");
 		osmo_serial_set_baudrate(dnload.serial_fd.fd, MODEM_BAUDRATE);
-		dnload.serial_fd.when = OSMO_FD_READ;
+		osmo_fd_update_when(&dnload.serial_fd, 0, OSMO_FD_READ);
 		dnload.mtk_state = MTK_FINISHED;
 		dnload.write_ptr = dnload.data;
 		dnload.expect_hdlc = 1;

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20767
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I65d37821873767e61a7eca029f9b30938a299683
Gerrit-Change-Number: 20767
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201111/de3acafa/attachment.htm>


More information about the gerrit-log mailing list