This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/21088 ) Change subject: l1sap: also include SRR bit in RSL l1 info field. ...................................................................... l1sap: also include SRR bit in RSL l1 info field. The SRR bit, which got specified in 3gpp release 6 to support repeated ACCH capability is not yet included in the L1 Information IE on RSL level. Also lets update the spec reference to more modern 3gpp spec ref numbers. Change-Id: I987c61608b737521ba36756dabf2f6215b34c2d6 Related: OS#4796 SYS#5114 --- M src/common/l1sap.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/21088/1 diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 316ea1b..7e8292a 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1410,12 +1410,12 @@ LOGPGT(DL1P, LOGL_NOTICE, &g_time, "SACCH with size %u<2 !?!\n", len); return -EINVAL; } - /* Some brilliant engineer decided that the ordering of - * fields on the Um interface is different from the - * order of fields in RSL. See TS 04.04 (Chapter 7.2) - * vs. TS 08.58 (Chapter 9.3.10). */ + /* Note: The ordering of the fields on the Um interface fields + * is reversed on RSL level, see also: 3GPP TS 44.004 (section 7.2) + * and 3GPP TS 48.058 (section 9.3.10). */ lchan->meas.l1_info[0] = data[0] << 3; - lchan->meas.l1_info[0] |= ((data[0] >> 5) & 1) << 2; + lchan->meas.l1_info[0] |= ((data[0] >> 5) & 1) << 2; /* FPC/EPC */ + lchan->meas.l1_info[0] |= ((data[0] >> 6) & 1) << 1; /* SRR */ lchan->meas.l1_info[1] = data[1]; lchan->meas.flags |= LC_UL_M_F_L1_VALID; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I987c61608b737521ba36756dabf2f6215b34c2d6 Gerrit-Change-Number: 21088 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201110/dedab7a5/attachment.htm>