Change in osmo-bsc[master]: osmo_bsc_bssap: actually check for lchan

[dexter]

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21086 )

Change subject: osmo_bsc_bssap: actually check for lchan
......................................................................

osmo_bsc_bssap: actually check for lchan

The function bssmap_handle_cipher_mode() suggests to check if an lchan
is actually present when it gets called, but it only checks for conn.
This might lead to a segfault later in the execution path.

Change-Id: I3103ec89cd6dce1a11ea8e9f8187373e4114e852
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  dexter: Looks good to me, approved



diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index f168b65..63dee9e 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -487,7 +487,7 @@
 	uint8_t enc_bits_msc;
 	int chosen_cipher;
 
-	if (!conn) {
+	if (!conn || !conn->lchan) {
 		LOGP(DMSC, LOGL_ERROR, "No lchan/msc_data in cipher mode command.\n");
 		return -1;
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21086
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3103ec89cd6dce1a11ea8e9f8187373e4114e852
Gerrit-Change-Number: 21086
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201110/490cc366/attachment.htm>