Change in osmo-ttcn3-hacks[master]: RLCMAC_EncDec: Fix Encoding of TLLI in UlEgprsDataBlock

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Nov 10 13:54:42 UTC 2020


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21066 )

Change subject: RLCMAC_EncDec: Fix Encoding of TLLI in UlEgprsDataBlock
......................................................................

RLCMAC_EncDec: Fix Encoding of TLLI in UlEgprsDataBlock

Change-Id: If13f36db9c86c10d7c5a6a307c430ee090b7dd06
---
M library/RLCMAC_EncDec.cc
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/library/RLCMAC_EncDec.cc b/library/RLCMAC_EncDec.cc
index c5fc447..4dba35a 100644
--- a/library/RLCMAC_EncDec.cc
+++ b/library/RLCMAC_EncDec.cc
@@ -1291,7 +1291,13 @@
 
 
 	if (in.tlli__ind()) {
-		aligned_buffer.put_string(in.tlli());
+		/* The TLLI is encoded in little endian for EGPRS (see
+		 * TS 44.060, figure 10.3a.2.1, note 2) */
+		OCTETSTRING tlli = in.tlli();
+		aligned_buffer.put_c(tlli[3].get_octet());
+		aligned_buffer.put_c(tlli[2].get_octet());
+		aligned_buffer.put_c(tlli[1].get_octet());
+		aligned_buffer.put_c(tlli[0].get_octet());
 	}
 
 	if (in.mac__hdr().pfi__ind()) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21066
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If13f36db9c86c10d7c5a6a307c430ee090b7dd06
Gerrit-Change-Number: 21066
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201110/0f52e04b/attachment.htm>


More information about the gerrit-log mailing list