Change in libosmocore[master]: gsm_08_58: add proprietary IE to signal Repeated ACCH Capability

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Nov 9 20:35:05 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21082 )

Change subject: gsm_08_58: add proprietary IE to signal Repeated ACCH Capability
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/21082/2/src/gsm/rsl.c 
File src/gsm/rsl.c:

https://gerrit.osmocom.org/c/libosmocore/+/21082/2/src/gsm/rsl.c@129 
PS2, Line 129: 		[RS
I would always add new IEs as TLV type.  After all, no generic TLV parser will know any TV/FIXED attributes.  So a receiver cannot even skip over this IE, unless it knows that it happens to be a TV.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21082
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I61ea6bf54ea90bd69b73ea0f0f3dc19a4214207b
Gerrit-Change-Number: 21082
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Nov 2020 20:35:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201109/2c153369/attachment.htm>


More information about the gerrit-log mailing list