Change in osmo-ttcn3-hacks[master]: RLCMAC_EncDec: Fix encoding of TI and E bits in UlEgprsDataBlock

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Nov 6 18:55:18 UTC 2020


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21064 )


Change subject: RLCMAC_EncDec: Fix encoding of TI and E bits in UlEgprsDataBlock
......................................................................

RLCMAC_EncDec: Fix encoding of TI and E bits in UlEgprsDataBlock

Change-Id: I442a12a16fe0d0664c677eec10bb81e2544235aa
---
M library/RLCMAC_EncDec.cc
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/21064/1

diff --git a/library/RLCMAC_EncDec.cc b/library/RLCMAC_EncDec.cc
index 6b78064..d900108 100644
--- a/library/RLCMAC_EncDec.cc
+++ b/library/RLCMAC_EncDec.cc
@@ -1181,7 +1181,6 @@
 	unsigned int data_block_bits, data_block_offsets[2];
 	unsigned int num_calls;
 	CodingScheme mcs;
-	boolean tlli_ind, e;
 
 	mcs = RLCMAC__Templates::f__rlcmac__cps__htype__to__mcs(in.mac__hdr().cps(), in.mac__hdr().header__type());
 	//fprintf(stderr, "RLCMAC: infered MCS %s (%d)\n", mcs.enum_to_str(static_cast<CodingScheme::enum_type>(mcs.as_int())), mcs.as_int());
@@ -1215,7 +1214,7 @@
 	}
 
 	/* Put first TI + E byte */
-	aligned_buffer.put_c(tlli_ind << 1 | e << 0); /* M=0, E=1 LEN=0 */
+	aligned_buffer.put_c((in.tlli__ind() & 0x01) << 1 | (in.e() & 0x01) << 0);
 	//printbuffer("After encoding first byte", aligned_buffer);
 
 	if (in.e() == false) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21064
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I442a12a16fe0d0664c677eec10bb81e2544235aa
Gerrit-Change-Number: 21064
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201106/d25b9ef2/attachment.htm>


More information about the gerrit-log mailing list