Change in osmo-pcu[master]: tbf_dl: Don't fake EGPRS MS class when no related info is available

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20936 )

Change subject: tbf_dl: Don't fake EGPRS MS class when no related info is available
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/20936/3/src/tbf_dl.cpp 
File src/tbf_dl.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/20936/3/src/tbf_dl.cpp@a134 
PS3, Line 134: LOGP(DTBF, LOGL_NOTICE, "Not accepting non-EGPRS phone in EGPRS-only mode\n");
             : 			bts->bts->do_rate_ctr_inc(CTR_TBF_FAILED_EGPRS_ONLY);
             : 			return NULL;
> I really disagree here. Having a clean "EGPRS only works" vs "GPRS only works" situation is good. […]
Well to me clearly having a GPRS-only phone connected to a network which can successfully transmit data from time to time is better than having one never being able to transmit.
And if you want ALL phones to be able to transmit, then you can still do so by configuring PCU to use only CS1-4 (GPRS-only) or/and MCS1-4 (EGPRS-GMSK).

And anyway, in the MCS5-9 enabled caseit's not like there's an obscure bug making it fail which we have to debug, why know why (USF possibly encoded in MCS-5-9). So in any case, this is only a temporary state until I implement the part where EGPRS dl data blocks are downgraded to MCS1-4 when MS owner of USF is GPRS-only.

So if you are really against merging this in this state, let's keep it here until I implemented that, but then I need to carry on my own branches on lots of patches moving/improving stuff around, and also changes in TTCN3-pcu tests, etc, having to rebase, etc.

So I'd prefer having all the submitted patches merged so I can concentrate on going forward instead of maintaining my own branches, which are growing every day.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20936
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Icce66cadb51af25ae0c3b3719940eccb548fe33b
Gerrit-Change-Number: 20936
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 06 Nov 2020 12:53:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201106/ceaf258b/attachment.htm>