Change in osmocom-bb[master]: trxcon/l1ctl_link: use osmo_store16be() in l1ctl_link_send()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Nov 5 13:55:37 UTC 2020


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/21048 )

Change subject: trxcon/l1ctl_link: use osmo_store16be() in l1ctl_link_send()
......................................................................

trxcon/l1ctl_link: use osmo_store16be() in l1ctl_link_send()

Change-Id: I96ca1c581d028a1f3c89c83a575fd8dbc9751962
---
M src/host/trxcon/l1ctl_link.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  neels: Looks good to me, approved



diff --git a/src/host/trxcon/l1ctl_link.c b/src/host/trxcon/l1ctl_link.c
index 2e2963a..4c406d6 100644
--- a/src/host/trxcon/l1ctl_link.c
+++ b/src/host/trxcon/l1ctl_link.c
@@ -184,7 +184,7 @@
 
 int l1ctl_link_send(struct l1ctl_link *l1l, struct msgb *msg)
 {
-	uint16_t *len;
+	uint8_t *len;
 
 	/* Debug print */
 	LOGP(DL1D, LOGL_DEBUG, "TX: '%s'\n",
@@ -194,8 +194,8 @@
 		LOGP(DL1D, LOGL_INFO, "Message L1 header != Message Data\n");
 
 	/* Prepend 16-bit length before sending */
-	len = (uint16_t *) msgb_push(msg, L1CTL_MSG_LEN_FIELD);
-	*len = htons(msg->len - L1CTL_MSG_LEN_FIELD);
+	len = msgb_push(msg, L1CTL_MSG_LEN_FIELD);
+	osmo_store16be(msg->len - L1CTL_MSG_LEN_FIELD, len);
 
 	if (osmo_wqueue_enqueue(&l1l->wq, msg) != 0) {
 		LOGP(DL1D, LOGL_ERROR, "Failed to enqueue msg!\n");

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/21048
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I96ca1c581d028a1f3c89c83a575fd8dbc9751962
Gerrit-Change-Number: 21048
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201105/228e4e74/attachment.htm>


More information about the gerrit-log mailing list