Change in osmo-pcu[master]: gprs_ms: Avoid enabling EGPRS if no MCS are supported

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Nov 4 21:25:23 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21046 )

Change subject: gprs_ms: Avoid enabling EGPRS if no MCS are supported
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/21046/2/src/gprs_ms.cpp 
File src/gprs_ms.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/21046/2/src/gprs_ms.cpp@546 
PS2, Line 546: Avoid enabling
This sounds like a recommendation to the user who reads logs, 'Not enabling' fits better IMHO.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21046
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ib19e9e006d851c2147de15f4aec36ab65250bdd3
Gerrit-Change-Number: 21046
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Nov 2020 21:25:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201104/6417bd04/attachment.htm>


More information about the gerrit-log mailing list