This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/20965 ) Change subject: main: use logging API to print SIMD info instead of printf() ...................................................................... main: use logging API to print SIMD info instead of printf() Otherwise these logging lines end up in the automatically generated XML VTY reference (stdout), so this breaks further XML processing. Change-Id: I8e0fd728d406e2452c9c0ddad5bce5f6b17fab42 Related: SYS#4937, SYS#4910 --- M Transceiver52M/osmo-trx.cpp 1 file changed, 33 insertions(+), 29 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index ba1c740..5099f89 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -478,6 +478,38 @@ return 0; } +static void print_simd_info(void) +{ +#ifdef HAVE_SSE3 + LOGP(DMAIN, LOGL_INFO, "SSE3 support compiled in"); +#ifdef HAVE___BUILTIN_CPU_SUPPORTS + if (__builtin_cpu_supports("sse3")) + LOGPC(DMAIN, LOGL_INFO, " and supported by CPU\n"); + else + LOGPC(DMAIN, LOGL_INFO, ", but not supported by CPU\n"); +#else + LOGPC(DMAIN, LOGL_INFO, ", but runtime SIMD detection disabled\n"); +#endif +#endif + +#ifdef HAVE_SSE4_1 + LOGP(DMAIN, LOGL_INFO, "SSE4.1 support compiled in"); +#ifdef HAVE___BUILTIN_CPU_SUPPORTS + if (__builtin_cpu_supports("sse4.1")) + LOGPC(DMAIN, LOGL_INFO, " and supported by CPU\n"); + else + LOGPC(DMAIN, LOGL_INFO, ", but not supported by CPU\n"); +#else + LOGPC(DMAIN, LOGL_INFO, ", but runtime SIMD detection disabled\n"); +#endif +#endif + +#ifndef HAVE_ATOMIC_OPS +#pragma message ("Built without atomic operation support. Using Mutex, it may affect performance!") + LOG(NOTICE) << "Built without atomic operation support. Using Mutex, it may affect performance!"; +#endif +} + static void print_config(struct trx_ctx *trx) { unsigned int i; @@ -585,35 +617,6 @@ g_trx_ctx = vty_trx_ctx_alloc(tall_trx_ctx); -#ifdef HAVE_SSE3 - printf("Info: SSE3 support compiled in"); -#ifdef HAVE___BUILTIN_CPU_SUPPORTS - if (__builtin_cpu_supports("sse3")) - printf(" and supported by CPU\n"); - else - printf(", but not supported by CPU\n"); -#else - printf(", but runtime SIMD detection disabled\n"); -#endif -#endif - -#ifdef HAVE_SSE4_1 - printf("Info: SSE4.1 support compiled in"); -#ifdef HAVE___BUILTIN_CPU_SUPPORTS - if (__builtin_cpu_supports("sse4.1")) - printf(" and supported by CPU\n"); - else - printf(", but not supported by CPU\n"); -#else - printf(", but runtime SIMD detection disabled\n"); -#endif -#endif - -#ifndef HAVE_ATOMIC_OPS -#pragma message ("Built without atomic operation support. Using Mutex, it may affect performance!") - printf("Built without atomic operation support. Using Mutex, it may affect performance!\n"); -#endif - convolve_init(); convert_init(); @@ -660,6 +663,7 @@ " but expect your config to break in the future."; } + print_simd_info(); print_config(g_trx_ctx); if (trx_validate_config(g_trx_ctx) < 0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20965 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8e0fd728d406e2452c9c0ddad5bce5f6b17fab42 Gerrit-Change-Number: 20965 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201104/2b23b6af/attachment.htm>