Change in osmo-pcu[master]: pcuif: Improve BTS-supported CS/MCS handling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Nov 4 10:41:50 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20990 )

Change subject: pcuif: Improve BTS-supported CS/MCS handling
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> Can you add some comments? I don't understand the function. Why is it returning initial_cs_dl?
> It's used by  gprs_bssgp_tx_fc_bvc(). This seems wrong.

You mean max_coding_scheme_dl()? Yes I agree it's wrong and needs to be improved/fixesd, but I'm not breaking it here now, I'm simply changing some variables to accomplish what the patch does.
I even add a FIXME in there in another followup commit where I also noticed that code logic is completely broken.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20990
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ie8f0215ba17da1e545e98bec9325c02f1e8efaea
Gerrit-Change-Number: 20990
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Wed, 04 Nov 2020 10:41:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201104/a09f4285/attachment.htm>


More information about the gerrit-log mailing list