Change in osmo-pcu[master]: NS2: follow the change of ownership

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Nov 3 22:37:49 UTC 2020


lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20913 )

Change subject: NS2: follow the change of ownership
......................................................................

NS2: follow the change of ownership

When receiving a primitive from the NS2 layer
the PCU must free the msg buffer if given.

Change-Id: I180433735bfbb3375c41318d7a7709d5845199ba
---
M src/gprs_bssgp_pcu.cpp
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index 413408d..671629b 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -597,7 +597,7 @@
 		LOGP(DPCU, LOGL_NOTICE, "NS: %s Unknown prim %d from NS\n",
 		     get_value_string(osmo_prim_op_names, oph->operation),
 		     oph->operation);
-		return 0;
+		goto out;
 	}
 
 	switch (oph->primitive) {
@@ -620,6 +620,10 @@
 		break;
 	}
 
+out:
+	if (oph->msg)
+		msgb_free(oph->msg);
+
 	return rc;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20913
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I180433735bfbb3375c41318d7a7709d5845199ba
Gerrit-Change-Number: 20913
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201103/021e817d/attachment.htm>


More information about the gerrit-log mailing list