Change in osmo-sgsn[master]: is_config_node is deprecated, so don't set it

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Tue Nov 3 20:32:07 UTC 2020


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21028 )

Change subject: is_config_node is deprecated, so don't set it
......................................................................


Patch Set 1: Code-Review-1

> Patch Set 1:
> 
> Don't you need to drop the function too?

No, it's still used in gbproxy_vty_go_parent()

However, it seems that vty_go_parent can also be NULL unless we need to do something special when exiting a node. At least the documentation mentions that changes to vty->node and index are ignored. So I'll redo the patch.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21028
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I2008dd9026922d29ee703c59e70d3fecced0ee18
Gerrit-Change-Number: 21028
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Nov 2020 20:32:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201103/44f09651/attachment.htm>


More information about the gerrit-log mailing list