Change in osmo-pcu[master]: tbf_dl: Don't fake EGPRS MS class when no related info is available

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20936 )

Change subject: tbf_dl: Don't fake EGPRS MS class when no related info is available
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/20936/3/src/tbf_dl.cpp 
File src/tbf_dl.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/20936/3/src/tbf_dl.cpp@a134 
PS3, Line 134: LOGP(DTBF, LOGL_NOTICE, "Not accepting non-EGPRS phone in EGPRS-only mode\n");
             : 			bts->bts->do_rate_ctr_inc(CTR_TBF_FAILED_EGPRS_ONLY);
             : 			return NULL;
> did we reach "the moment" before this patch?  Then yes, it can be removed. […]
"The moment" is not yet there, but we are simply missing the part where we downgrade a DL msg to MCS1-4 in case the USF to send relates toa TBF from an MS not supporting EGPRS.

And in any case, dropping this code doesn't make worse the current situation. It acutally makes the situation better since it will allow GPRS-only MS and they will work as long as other MS don't use MCS-48 on the same PDCH slot.

So let's go for getting rid of this "egprs" flag and fix specific issues later on.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20936
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Icce66cadb51af25ae0c3b3719940eccb548fe33b
Gerrit-Change-Number: 20936
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 02 Nov 2020 17:34:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201102/fdd42b67/attachment.htm>