Change in osmo-trx[master]: vty: remove groundless statement about filler type 'dummy'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Nov 2 10:54:15 UTC 2020


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/20975 )

Change subject: vty: remove groundless statement about filler type 'dummy'
......................................................................

vty: remove groundless statement about filler type 'dummy'

Dummy bursts have nothing to do with A5/x encryption, and I see
no reason why (and how?!?) would using that filler type break
encryption in osmo-bts-trx.  I asked the author of this code
back in August 2020 [1], and so far didn't get any response.

[1] https://lists.osmocom.org/pipermail/openbsc/2020-August/013208.html

Change-Id: Iae513d7acbb8ef682e1744ac8726cbd6ece8bd87
---
M CommonLibs/trx_vty.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c
index adce897..4e265b6 100644
--- a/CommonLibs/trx_vty.c
+++ b/CommonLibs/trx_vty.c
@@ -333,8 +333,7 @@
 	"Filler burst settings\n"
 	"Filler burst type (default=zero)\n"
 	"Send an empty burst when there is nothing to send (default)\n"
-	"Send a dummy burst when there is nothing to send on C0 (TRX0) and empty burst on other channels."
-	" Use for OpenBTS compatibility only, don't use with OsmoBTS as it breaks encryption.\n"
+	"Send a dummy burst when there is nothing to send on C0 (TRX0) and empty burst on other channels.\n"
 	"Send a GMSK modulated Normal Burst with random bits when there is nothing to send."
 	" Use for spectrum mask testing. Configure 'filler tsc' to set training sequence.\n"
 	"Send an 8-PSK modulated Normal Burst with random bits when there is nothing to send."

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20975
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Iae513d7acbb8ef682e1744ac8726cbd6ece8bd87
Gerrit-Change-Number: 20975
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201102/5a50d532/attachment.htm>


More information about the gerrit-log mailing list