Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: improve SGSN originated BVC-RESETs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Nov 2 09:43:23 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20923 )

Change subject: PCU_Tests_SNS: improve SGSN originated BVC-RESETs
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20923/1/pcu/PCU_Tests_SNS.ttcn 
File pcu/PCU_Tests_SNS.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20923/1/pcu/PCU_Tests_SNS.ttcn@290 
PS1, Line 290: 		/
> The problem is f_ns_exp() is catching NS_ALIVE even the alt state in 281/283 should handle those.
the activated/default altstep always comes last.  so if you have a receive() statement that catches/matches NS-ALIVE before the end of the alt{} clause in f_ns_exp(), then that will match and you will never reach your activated/default altstep.

One way around that would be to explicitly include 
[] as_rx_alive_tx_ack(idx := 1)
[] as_rx_alive_tx_ack(idx := 0)

from f_ns_exp(), but that would make the function less generic.

I guess the root problem is the "t_NS_RecvFrom(?)" clause in f_ns_exp().

Maybe that one should also be converted into an altstep and activated last (i.e. just before going into the alt{} in f_ns_exp).  It should then have lowest priority, after those that the caller activated first.

The "receive any and error" altstep activated from within f_ns_exp then obvoiusly needs to be deactivated before the function returns.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20923
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id681749d75073c1d50a4b0a2e86f0a2dd0955b45
Gerrit-Change-Number: 20923
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 02 Nov 2020 09:43:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201102/c3cebee9/attachment.htm>


More information about the gerrit-log mailing list