Change in osmo-bts[master]: vty: call bts_model_vty_init() from bts_vty_init()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Nov 2 09:33:18 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21011 )

Change subject: vty: call bts_model_vty_init() from bts_vty_init()
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> I'm not a big fan in this, as the idea that only one logical "BTS" lives within osmo-bts is (as the TODO states) a hack and nothing that we want to perpetuate even further.
> 
> There is hardware out there (e.g. osmo-bts-octphy) where the PHY handles multiple TRX in one "instance" of the PHY API.  You can use those multiple TRX as different TRX of the same BTS, but there may also be configurations where you actually want to operate multiple logical BTS on those TRX.  Running two instances of osmo-bts is not possible as you only have one PHY interface/API/... to attach to.

Neither I am a fan of the current 'single & global BTS' approach, and it's not like my code introducing this hack. I am simply moving things around, because my first attempt to un-globalize the 'struct gsm_bts' instance took me too much time: it's relatively easy for osmo-bts-trx, but osmo-trx-sysmo and the copy-pasted variants (sorry, but there actually is quite a lot of duplicated code) register VTY commands, where the single BTS is assumed and you cannot select specific BTS. So I had to stash everything and proceed with this approach. How should I proceed?


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21011
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iee7fee6747dd1e7c0af36f9b27326f651ae37aaf
Gerrit-Change-Number: 21011
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 02 Nov 2020 09:33:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201102/0f9a5667/attachment.htm>


More information about the gerrit-log mailing list