Change in osmo-bsc[master]: bts_sysmobts: fix: properly zero-initialize the feature vector

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun May 31 18:44:29 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18608 )

Change subject: bts_sysmobts: fix: properly zero-initialize the feature vector
......................................................................

bts_sysmobts: fix: properly zero-initialize the feature vector

The last argument must be size of buffer, not size of size!

Change-Id: I6539a3c9829d4f74a18b1cc2aa522c69ff8e638d
---
M src/osmo-bsc/bts_sysmobts.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/osmo-bsc/bts_sysmobts.c b/src/osmo-bsc/bts_sysmobts.c
index 2537864..ad12733 100644
--- a/src/osmo-bsc/bts_sysmobts.c
+++ b/src/osmo-bsc/bts_sysmobts.c
@@ -54,7 +54,7 @@
 	model_sysmobts.features.data = &model_sysmobts._features_data[0];
 	model_sysmobts.features.data_len =
 				sizeof(model_sysmobts._features_data);
-	memset(model_sysmobts.features.data, 0, sizeof(model_sysmobts.features.data_len));
+	memset(model_sysmobts.features.data, 0, model_sysmobts.features.data_len);
 
         osmo_bts_set_feature(&model_sysmobts.features, BTS_FEAT_GPRS);
 	osmo_bts_set_feature(&model_sysmobts.features, BTS_FEAT_EGPRS);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18608
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6539a3c9829d4f74a18b1cc2aa522c69ff8e638d
Gerrit-Change-Number: 18608
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200531/e23099e0/attachment.htm>


More information about the gerrit-log mailing list