This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18505 ) Change subject: refactor bsc_find_msc()'s round-robin ...................................................................... Patch Set 3: > Patch Set 3: > > (3 comments) > > AS I said, I'd rather implement the roundrobin by keeping a pointer to last/next msc's llisthead. Since we have and use llists here, let's use their benefits. Keeping an actual pointer has one fundamental flaw: if the MSC gets removed for any reason, the pointer points at a segmentation fault, and it is a potential source of hard to fix bugs. Of course, I think we actually have no way of removing MSCs from osmo-bsc, do we? But consider that we could at some point introduce a 'no msc 2' command to change MSC pooling in a live running BSC instance without restart. It is actually likely to be requested by a customer at some point. If I keep an msc_nr, no matter how many MSCs we add or remove, re-iterating existing MSCs will never ever end up with a segfault situation. That is why I would prefer to stay with storing MSC numbers instead of pointers. Also, we won't really save any cycles, because for NRI matching, we need to iterate all MSCs anyway. Having a direct pointer will not be more optimal. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idf71f07ba5a17d5b870dc1a5a2875b6fedb61291 Gerrit-Change-Number: 18505 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 29 May 2020 20:38:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200529/421c0d1a/attachment.htm>